Inspired

**MAFoElffen** · September 18th, 2021

@ Doug... For you.

Code:

mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git add system-info
mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$  git commit -m "Renamed GetVersion() to GetArgs(). Now includes more  external arguments."
[main 6433629] Renamed GetVersion() to GetArgs(). Now includes more external arguments.
 1 file changed, 46 insertions(+), 20 deletions(-)
mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 4 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 1.16 KiB | 595.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: This repository moved. Please use the new location:
remote:   https://github.com/Mafoelffen1/system-info.git
To https://github.com/MAFoElffen1/system-info
   d703fc7..6433629  main -> main
mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$

Of interest to you... I only have some of the debug code re-added so far...

Code:

mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ ./system-info --help
Running Script: system-info Version: 01.00-00, Script Date: 2021.09.15
md5sum: 95f799fe5a2974bcc5f61f1a0a1215a1

Description: The Ubuntu Forums "system-info" script queries the users 
computer and prepares a report, so that Ubuntu Forums Community Members 
can see what they are recommending solutions for.

Usage:    ./system-info <option> 

Options: 
    -v              Returns Version Information and exits.
    -h or --help    Displays this Help Screen, then exits.
    -s # or --show  #  Changes Verbosity levels of the logger.
        # range 0 through 5
        Example: system-info -s 5  turns on debugging messages

Asks the user 2 questions to describe the problem they are having, then 
creates system-info.txt in their Home directory.

Will check programs used by this script, and give the user the option to 
quit to install anything it finds missing. Will give the user the option 
to upload the report to a pastebin and displays the URL of that to add 
their post on Ubuntu Forums.

Or they can manually paste the report within code tags in a post or to a 
pastebin. Or added as a text attachment to a post.

We have tried to keep this safe and simple to use.

**Doug S** · September 18th, 2021

Hi, and thank you,

I get:

Code:

doug@s19:~/tmp/system-info$ ./system-info --show 5
./system-info: line 125: [: arg2: integer expression expected
Option out of range.
doug@s19:~/tmp/system-info$ ./system-info -s 5
./system-info: line 125: [: arg2: integer expression expected
Option out of range.
doug@s19:~/tmp/system-info$

So, if I do this:

Code:

doug@s19:~/tmp/system-info$ git diff
diff --git a/system-info b/system-info
index 03a085a..36c0cce 100755
--- a/system-info
+++ b/system-info
@@ -122,7 +122,7 @@ function CheckArgs()
         exit;
     elif [[ "$arg1" == "-s" ]] || [[ "$arg1" == "--show" ]]
     then
-        if [ arg2 -ge -1 ] && [ arg2 -le 5 ]
+        if [ $arg2 -ge -1 ] && [ $arg2 -le 5 ]
         then
             verbosity=$arg2
         else
doug@s19:~/tmp/system-info$

it works, but then I get this:

Code:

[sudo] password for doug:
Running Script: system-info Version: 01.00-00, Script Date: 2021.09.15
ubuntu-drivers is not installed.

The Script 'system-info' uses  some very basic Linux utilities.
Some of these utilities were not found.
<E>xit and install the program(s) or <C>ontinue anyway? <E/C> E
2021-09-18  08:29:39 PDT (-0700) DEBUG: User answered e
Please install the missing programs listed above before rerunning script.

which I was not expecting, so I aborted. I see it in "6433629 Renamed GetVersion() to GetArgs(). Now includes more external arguments." but want to look into what it is first.

Code:

@@ -135,6 +148,8 @@ function CheckPrerequisites()
        mokutil
        curl
        pastebinit
+       ubuntu-drivers
+       dpkg
        nc
        wget
        ls

EDIT: Actually, I can not find a package called "ubuntu-drivers". I did find one called "ubuntu-drivers-common", but have yet to figure out why it might be needed.

**MAFoElffen** · September 18th, 2021

Oh Dang. As susdodus put it, I needed to "Debug debug()". LOL

Code:

[sudo] password for mafoelffen: 
Running Script: system-info Version: 01.00-00, Script Date: 2021.09.15
 "mokutil" could not be found. This program is suggested.
If this is older hardware that is 'Legacy Only BIOS', then this can be ignored.

The Script 'system-info' uses  some very basic Linux utilities. 
Some of these utilities were not found.
<E>xit and install the program(s) or <C>ontinue anyway? <E/C> ^C
mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git add system-info
mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git commit -m "debugged GetArgs() for Logger. Or as someone said, debugged debugger."
[main 8392925] debugged GetArgs() for Logger. Or as someone said, debugged debugger.
 1 file changed, 1 insertion(+), 1 deletion(-)
mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 4 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 354 bytes | 354.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: This repository moved. Please use the new location:
remote:   https://github.com/Mafoelffen1/system-info.git
To https://github.com/MAFoElffen1/system

**MAFoElffen** · September 20th, 2021

Originally Posted by Doug S

Hi, and thank you,

I get:

Code:

doug@s19:~/tmp/system-info$ ./system-info --show 5
./system-info: line 125: [: arg2: integer expression expected
Option out of range.
doug@s19:~/tmp/system-info$ ./system-info -s 5
./system-info: line 125: [: arg2: integer expression expected
Option out of range.
doug@s19:~/tmp/system-info$

Fixed

Code:

[sudo] password for doug:
Running Script: system-info Version: 01.00-00, Script Date: 2021.09.15
ubuntu-drivers is not installed.

The Script 'system-info' uses  some very basic Linux utilities.
Some of these utilities were not found.
<E>xit and install the program(s) or <C>ontinue anyway? <E/C> E
2021-09-18  08:29:39 PDT (-0700) DEBUG: User answered e
Please install the missing programs listed above before rerunning script.

which I was not expecting, so I aborted. I see it in "6433629 Renamed GetVersion() to GetArgs(). Now includes more external arguments." but want to look into what it is first.

Code:

@@ -135,6 +148,8 @@ function CheckPrerequisites()
        mokutil
        curl
        pastebinit
+       ubuntu-drivers
+       dpkg
        nc
        wget
        ls

EDIT: Actually, I can not find a package called "ubuntu-drivers". I did find one called "ubuntu-drivers-common", but have yet to figure out why it might be needed.

That command is either in package ubuntu-drivers-common or ubuntu-drivers-extra, depending on the version of the Ubuntu Release. It has to do with installing hardware drivers to Ubuntu flavored distros, but has a routine within it which it uses to see if something it is running on "is" an "Ubuntu Hardware Certified Platform". That tells a lot about if a hardware platform can or cannot have HWE installed on it, without causing any problems to it, from that. It has been a growing support problem lately (the last two months) with both 18.04 and 20.04.

If I could isolate, what it uses to determine "that"... I would just add that query directly within my script and not use that command. But I haven't been able to isolate that (yet). If anyone knows what that may be, or where that "is" documented, please contact me so I can use that. (Even if I have to code that in C and call it from this script!!!)
It does tell us (along with the other two HWE related queries) if a user install HWE to their PC, and it was not safe to do so. The requirements for HWE and what it weill actually support is buried in the Wiki and documents, so that is not always clear to users, or support of.

EDIT: I actually entered that as a question to Ubuntu Launchpad. I don't know if it will get answered by anyone there... But is in our favor for this script, if it does. I've supported Launchpad for years, It's about time I see I get anything back in return. LOL Heck... I'll contact the maintainer if I have to.

**Doug S** · September 20th, 2021

O.K. thanks for the explanations. And yes, now I see that "ubuntu-drivers" is contained within the package "ubuntu-drivers-common". I got the source code via:

Code:

$ git clone https://git.launchpad.net/ubuntu/+source/ubuntu-drivers-common

There is a README file, and code itself is in python3. I haven't dug into it yet, and don't know when I'll have time to.

**MAFoElffen** · September 23rd, 2021

So far, so good. I took a day off from my certifications to visit the non=profit Computer Recycler I used to volunteer for. I looked over some of his PXE images on his deployment server for him. He is a big proponent of Linux and OpenSource. I showed him the script and we took a reconditioned iMAC and installed Ubuntu to test the script on it. (He is going to keep an eye out for a MAC notebook that I can test and debug on, for the Ama-gi Project.

Here is the script running on an iMAC running 20.04.3: https://termbin.com/8uqg

I do notice there is a small number of things that did not show up on the report on the system, and BIOS information. But they did show up in output after the report generated(???) so I'm thinking it went to stderr, and was not captured in the report.

**MAFoElffen** · September 29th, 2021

This is on my Lenovo T-520. With the test on the iMAC and on this laptop, I noticed that the GetSb() was displaying to screen, but was not including it in the report... So debugged it and will puch the changes tonight. Will post when I push those changes to the repo's.

**MAFoElffen** · September 30th, 2021

Piushed changes to both Repo's

Code:

mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git add system-info

mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git commit -m "Updated/fixed GetSb()."
[main 3176633] Updated/fixed GetSb().
 1 file changed, 9 insertions(+), 5 deletions(-)

mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 4 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 445 bytes | 445.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: This repository moved. Please use the new location:
remote:   https://github.com/Mafoelffen1/system-info.git
To https://github.com/MAFoElffen1/system-info
   8392925..3176633  main -> main

mafoelffen@ubuntu:~/git$ cd UbuntuForums/system-info

mafoelffen@ubuntu:~/git/UbuntuForums/system-info$ git add system-info

mafoelffen@ubuntu:~/git/UbuntuForums/system-info$ git commit -m "Updated/fixed GetSb()."
[main eff60f9] Updated/fixed GetSb().
 1 file changed, 54 insertions(+), 24 deletions(-)
mafoelffen@ubuntu:~/git/UbuntuForums/system-info$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 4 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 1.24 KiB | 422.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To https://github.com/UbuntuForums/system-info
   e63e84b..eff60f9  main -> main

**Doug S** · September 30th, 2021

O.K., I did a "git pull" and am at:

Code:

doug@s19:~/system-info$ git log --oneline
eff60f9 (HEAD -> main, origin/main, origin/HEAD) Updated/fixed GetSb().
e63e84b Updated GetVersion().
a1fb8aa Updated GetSb().
b77acf2 Updated all files for UbuntuForums Release.

And get:

Code:

doug@s19:~/system-info$ ./system-info --show 5
./system-info: line 241: syntax error near unexpected token `('
./system-info: line 241: `    read -p "What is the Main Complaint (summarized)? " main_complaint'
doug@s19:~/system-info$ ./system-info
./system-info: line 241: syntax error near unexpected token `('
./system-info: line 241: `    read -p "What is the Main Complaint (summarized)? " main_complaint'

And on the other one:

Code:

doug@s19:~/tmp/system-info$ git log --oneline
3176633 (HEAD -> main, origin/main, origin/HEAD) Updated/fixed GetSb().
8392925 debugged GetArgs() for Logger. Or as someone said, debugged debugger.
3d917f4 Renamed GetVersion() to GetArgs(). Now includes more external arguments.
6433629 Renamed GetVersion() to GetArgs(). Now includes more external arguments.
d703fc7 Updated GetVersion().
0182991 Updated GetSb().
0690364 Updated all files for push to UbuntuForums and Release.

And get:

Code:

doug@s19:~/tmp/system-info$ ./system-info
./system-info: line 241: syntax error near unexpected token `('
./system-info: line 241: `    read -p "What is the Main Complaint (summarized)? " main_complaint'
doug@s19:~/tmp/system-info$ ./system-info --show 5
./system-info: line 241: syntax error near unexpected token `('
./system-info: line 241: `    read -p "What is the Main Complaint (summarized)? " main_complaint'

EDIT 1: If I go back one commit:

Code:

doug@s19:~/tmp/system-info$ git checkout 8392925

it works.

EDIT 2: The fix:

Code:

doug@s19:~/tmp/system-info$ git diff
diff --git a/system-info b/system-info
index 8cf6934..b0ee0e8 100755
--- a/system-info
+++ b/system-info
@@ -192,7 +192,7 @@ function CheckPrerequisites()
                 echo -e "$Program is not installed."
                 check_prog=0;
             fi
-            echo -e ' -------------------------------- "
+            echo -e " -------------------------------- "
         fi
     done

**MAFoElffen** · September 30th, 2021

Thank you @Doug S and @TheFU...

Dang. I hate when that happens...

Fixed:

Code:

mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git add system-info

mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git commit -m "Fixed unclosed quotation at line 195."
[main 1cf701a] Fixed unclosed quotation at line 195.
 1 file changed, 2 insertions(+), 2 deletions(-)

mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 4 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 331 bytes | 331.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: This repository moved. Please use the new location:
remote:   https://github.com/Mafoelffen1/system-info.git
To https://github.com/MAFoElffen1/system-info
   3176633..1cf701a  main -> main


mafoelffen@ubuntu:~/git/UbuntuForums/system-info$ git add system-info

mafoelffen@ubuntu:~/git/UbuntuForums/system-info$ git commit -m "Fixed unclosed quotation at line 195."
[main 198af03] Fixed unclosed quotation at line 195.
 1 file changed, 2 insertions(+), 2 deletions(-)

mafoelffen@ubuntu:~/git/UbuntuForums/system-info$ git push
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 4 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 330 bytes | 330.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
To https://github.com/UbuntuForums/system-info
   eff60f9..198af03  main -> main

Thread: Inspired

Thread Tools

Display

Re: Inspired

Re: Inspired

Re: Inspired

Re: Inspired

Re: Inspired

Re: Inspired

Re: Inspired

Re: Inspired

Re: Inspired

Re: Inspired

Bookmarks

Bookmarks

Posting Permissions