Page 27 of 35 FirstFirst ... 172526272829 ... LastLast
Results 261 to 270 of 347

Thread: Inspired

  1. #261
    Join Date
    Mar 2010
    Location
    USA
    Beans
    Hidden!
    Distro
    Ubuntu Development Release

    Re: Inspired

    What I just pushed to MAFoElffen1/system-info/system-info is what I have as current.

    I finished a new Paster() that uses 'curl'... and integrated it into how we are doing that.I may have to tune it adding timeout and retry's... but that has that within it.

    Concurrent coexistance of Windows, Linux and UNIX...
    Ubuntu user # 33563, Linux user # 533637
    Sticky: [all variants] Graphics Resolution- Upgrade /Blank Screen after reboot
    UbuntuForums system-info Script

  2. #262
    Join Date
    Nov 2011
    Location
    /dev/root
    Beans
    Hidden!

    Re: Inspired

    @MAFoElffen,

    There are at least 3 bugs in your previous version from your own github site:

    - the plus bug (see attachment in post #244)

    - the mokutil bug (see the same attachment)

    - the sourcesD bug (an error output shows up, when there are no repos in .d/ directories).

    In my newest version I have fixed those bugs. Maybe you think they are only making things look ugly on the screen or terminal window; the report file will be OK, but anyway ...



    I will fetch the new version of our script and test it

    I'm glad that @TheFu showed a way to eliminate the need for pastebinit. It used to be bundled (at least until 18.04.x LTS), but must be installed in Ubuntu Desktop 20.04 LTS.
    Last edited by sudodus; September 7th, 2021 at 12:07 PM.

  3. #263
    Join Date
    Nov 2011
    Location
    /dev/root
    Beans
    Hidden!

    Re: Inspired

    @MAFoElffen,

    I tested what I think is your newest version of the system-info script, found the 3 bugs and another bug too: the name of the link log file to be flexible as well as the report file. I fixed these bugs, tested in two computers and made a patch file.

    Starting from the name system-info.1 I made the following patch file,

    Code:
    --- testing/system-info.1	2021-09-07 11:53:28.810041865 +0200
    +++ system-infoV	2021-09-07 11:45:30.350764733 +0200
    @@ -91,6 +91,7 @@
         	free
         	gsettings
         	gzip
    +    	mokutil
         	curl
         	ls
         	rm
    @@ -288,7 +289,7 @@
         if [ $check_mokutil -eq 0 ] 
         then
             echo -e "\tThis would check / have checked if SecureBoot was enabled or not, "
    -        echo -e "\t and checks if the system BIOS was UEFI or Lagacy only BIOS, "
    +        echo -e "\tand checks if the system BIOS was UEFI or Lagacy only BIOS, "
             echo -e "\tbut package mokutil was not installed. If you would like to check"
             echo -e "\tthis information, please install 'mokutil' and rerun script."
         else
    @@ -542,13 +543,17 @@
         echo -e "${setansi}---------- Repository Information:$ransi"
         nl
         sources=$(grep -v '#' /etc/apt/sources.list | sed -e /^$/d )
    -    sourcesd=$(grep -v '#' /etc/apt/sources.list.d/* | sed -e /^$/d)
         echo -e "Sources List:"
         echo -e "$sources"
         nl
    -    echo -e "Sources List from SourcesD:"
    -    echo -e "$sourcesd"
    -    nl
    +    if [ $(find /etc/apt/sources.list.d/ -type f 2> /dev/null | wc -l) -ne 0 ]
    +    then
    +        sourcesd=$(grep -v '#' /etc/apt/sources.list.d/* | sed -e /^$/d \
    +         | sed 's/:deb/:\n  deb/')
    +        echo -e "Sources List from SourcesD:"
    +        echo -e "$sourcesd"
    +        nl
    +    fi
     }
     
     function GetOtherDetails()
    @@ -661,7 +666,8 @@
         echo -e "you can also navigate with the mouse or touchpad."
         echo -e "Get more built-in help within 'less' with the <H> key."
         echo -e "At any point while in 'less' or if you see this '(END)' prompt"
    -    echo -e "at the lower left of your screen,"+    echo -e "$blueback quit from 'less' to continue the script with the <q> key. $resetvid"
    +    echo -e "at the lower left of your screen,"
    +    echo -e "$blueback quit from 'less' to continue the script with the <q> key. $resetvid"
         nl
      }
      
    @@ -722,7 +728,8 @@
      {
          # Provides curl upload of report with a progress bar. Called once by Main().
          target="https://paste.ubuntu.com"
    -     linklog="$HOME/system-info-link.log"
    +     linklog="$HOME/${sname}-link.log"
    +#     linklog="$HOME/system-info-link.log"
     
          echo -e "$blueback Sensitive data is [REMOVED] from the report file $resetvid"
          CheckCurl  # Check if 'curl' is installed and set check_curl. 0 if true, 1 if false
    After these fixes, I am rather satisfied with the performance and looks of our system-info script.

    - It works with curl, so that we need not install pastebinit

    - Is it enough with one day's lifetime of the uploaded file at the Ubuntu pastebin? What if the helper spends a day or weekend in RL? I suggest one week (instead of one day). I did not change it, (because there might be strong reasons for keeping it at one single day).

    - I added mokutil to the checklist. This creates a redback text, if it is not installed. You may not like that. An alternative is to check for the existence when you intend to use mokutil in a way to eliminate an error message. You may want to tweak this.

    - I fixed the bug for Sources List from SourcesD.

    - I made the link log file name flexible (that it follows the name of the shellscript).

    - There are also some small edits to the text to be written (including the 'plus' bug).

    Link to 'my' new version, system-info-nio: https://paste.ubuntu.com/p/xzS6hvBtBH/

  4. #264
    Join Date
    Feb 2011
    Location
    Coquitlam, B.C. Canada
    Beans
    3,040
    Distro
    Ubuntu Development Release

    Re: Inspired

    Quote Originally Posted by TheFu View Post
    Aren't people doing modifications using git? That seems like a reasonable low-bar to have changes incorporated - that an providing a "pull" request to MAFoElffen. Git is designed exactly for this use - teams working on the same code.
    While I agree, I don't actually know how to work with pull requests yet, but will try to learn. (my experience has always been via git email to send patches to the upstream kernel).

    @MAFoElffen, The permissions are still incorrect in your git branch. Please apply this patch:

    Code:
    doug@s19:~/tmp/support-info$ cat 0001-Set-support-info-to-be-executable.patch
    From ff64028198c79f599555b4f54280b2f4109c8f8c Mon Sep 17 00:00:00 2001
    From: Doug Smythies <dsmythies@telus.net>
    Date: Tue, 7 Sep 2021 06:46:51 -0700
    Subject: [PATCH] Set support-info to be executable.
    
    The file permissions for the script are not executable. Make it executable.
    
    Signed-off-by: Doug Smythies <dsmythies@telus.net>
    ---
     system-info | 0
     1 file changed, 0 insertions(+), 0 deletions(-)
     mode change 100644 => 100755 system-info
    
    diff --git a/system-info b/system-info
    old mode 100644
    new mode 100755
    --
    2.25.1
    From my branch:
    Code:
    doug@s19:~/tmp/support-info$ git log --oneline
    ff64028 (HEAD -> doug2) Set support-info to be executable.
    2ff7fed (origin/main, origin/HEAD, main) Update system-info
    4084f6c Update system-info
    2862dd8 Update and rename UbuntuForum-README.md to UbuntuForums-README.md
    5bd57d5 Create UbuntuForum-README.md
    3c2a3ce Update system-info
    381bfd5 Update system-info
    83c9467 Update system-info
    0308906 Update system-info
    c761b4b Update system-info
    96b98b7 Update system-info
    551f823 Update README.md
    910ea4b Update system-info
    9517a97 Rename support-info to system-info
    253145d Update README.md
    c8ccd0f Update README.md
    6e2fb6f Update README.md
    2647313 Update README.md
    6e67887 Update README.md
    fa970f0 Update README.md
    c40dc86 Create support-info
    bb4a5f1 Initial commit
    Any follow-up information on your issue would be appreciated. Please have the courtesy to report back.

  5. #265
    Join Date
    Nov 2011
    Location
    /dev/root
    Beans
    Hidden!

    Re: Inspired

    Quote Originally Posted by Doug S View Post
    Quote Originally Posted by TheFu View Post
    Aren't people doing modifications using git? That seems like a reasonable low-bar to have changes incorporated - that an providing a "pull" request to MAFoElffen. Git is designed exactly for this use - teams working on the same code.
    While I agree, I don't actually know how to work with pull requests yet, but will try to learn. (my experience has always been via git email to send patches to the upstream kernel).
    I use github too and have a git directory in my computer. It works well. But I have never cooperated via Git, and would also need instructions how to do it.

  6. #266
    Join Date
    Mar 2010
    Location
    USA
    Beans
    Hidden!
    Distro
    Ubuntu Development Release

    Re: Inspired

    Is it enough with one day's lifetime of the uploaded file at the Ubuntu pastebin? What if the helper spends a day or weekend in RL? I suggest one week (instead of one day). I did not change it, (because there might be strong reasons for keeping it at one single day).
    I was thinking when it goes live, that it should probably set to a week or possibly month.

    I set it as a Day for now, as the script "is a test", and we are generating pastes that are not that important, except that they get there. LOL These all are tests.

    I'm working on the new patches and should take care of those last 3 bugs. And since you 2 tested the new Paster with curl, now I can surgically remove pastebinit from the script.

    I'm going to push this "snapshot" of the script to UbuntuForums. Better to do it with all know bugs taken care of than before I start taking pastebinit out... I know all the intertwined pieces that are involved... but for the just-it-causes, LOL.

    EDIT: Pushed to UbuntuForums and fixed/closed an Open Issue there.

    Waiting on an answer from someone to Doug's question, to see if that is something that can be changed "there", or if it just because the code up there is stored as Web Documents...
    Last edited by MAFoElffen; September 7th, 2021 at 07:31 PM.

    Concurrent coexistance of Windows, Linux and UNIX...
    Ubuntu user # 33563, Linux user # 533637
    Sticky: [all variants] Graphics Resolution- Upgrade /Blank Screen after reboot
    UbuntuForums system-info Script

  7. #267
    Join Date
    Nov 2011
    Location
    /dev/root
    Beans
    Hidden!

    Re: Inspired

    +1



    @MAFoElffen,

    Edit: Maybe this is what you want to know: You can upload edited versions of README.md just like you edit the system-info script, and upload it. Then it will render according to the formatting (similar to AskUbuntu and discourse.ubuntu.com).
    Last edited by sudodus; September 7th, 2021 at 08:52 PM.

  8. #268
    Join Date
    Feb 2011
    Location
    Coquitlam, B.C. Canada
    Beans
    3,040
    Distro
    Ubuntu Development Release

    Re: Inspired

    Quote Originally Posted by MAFoElffen View Post
    I was thinking when it goes live, that it should probably set to a week or possibly month.

    I set it as a Day for now, as the script "is a test", and we are generating pastes that are not that important, except that they get there. LOL These all are tests.
    While I totally agree, I also can easily be 2 or 3 days behind, and would prefer a week even during this testing phase.

    Quote Originally Posted by MAFoElffen View Post
    Waiting on an answer from someone to Doug's question, to see if that is something that can be changed "there", or if it just because the code up there is stored as Web Documents...
    There wasn't a question. It should work fine. I have cloned many HTTPS gits and the permissions have typically been correct for execution.
    Any follow-up information on your issue would be appreciated. Please have the courtesy to report back.

  9. #269
    Join Date
    Mar 2010
    Location
    USA
    Beans
    Hidden!
    Distro
    Ubuntu Development Release

    Re: Inspired

    Got back home.

    Changed the duration to a week for the pastes in Paster() in system-info on both the TEST and Stable Repo's.

    Also pushed a commit to both Repo's fixing the file permissions on system-info on both Repo's.
    Code:
    mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git ls-tree HEAD
    100644 blob f288702d2fa16d3cdf0035b15a9fcbc552cd88e7    LICENSE
    100644 blob 9a2ce7388c513c9d2862ef50f30246600ef2dc6f    README.md
    100644 blob 3728ecfc0ad7152bc8083e5e35ee69d5c06ac988    UbuntuForums-README.md
    100755 blob c018cf0ea4246d3aaf428ddb87e93a7007be20d6    system-info
    
    mafoelffen@ubuntu:~/git/UbuntuForums/system-info$ git ls-tree HEAD
    100644 blob f288702d2fa16d3cdf0035b15a9fcbc552cd88e7    LICENSE
    100644 blob 3728ecfc0ad7152bc8083e5e35ee69d5c06ac988    README.md
    100755 blob c018cf0ea4246d3aaf428ddb87e93a7007be20d6    system-info
    Updated MAFoElffen1/system-info
    - Removed old version of Paster() that used pasteibinit and all references to pastebinit.
    Code:
    mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git add system-info
    mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git commit -m "Removed old Paster() and all traces using pastebinit"
    [main 7d757a5] Removed old Paster() and all traces using pastebinit
     1 file changed, 7 insertions(+), 79 deletions(-)
    mafoelffen@ubuntu:~/git/MAFoElffen1/system-info$ git push
    Enumerating objects: 5, done.
    Counting objects: 100% (5/5), done.
    Delta compression using up to 4 threads
    Compressing objects: 100% (3/3), done.
    Writing objects: 100% (3/3), 527 bytes | 527.00 KiB/s, done.
    Total 3 (delta 2), reused 0 (delta 0)
    remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
    remote: This repository moved. Please use the new location:
    remote:   https://github.com/Mafoelffen1/system-info.git
    To https://github.com/MAFoElffen1/system-info
       d1eaa39..7d757a5  main -> main
    Last edited by MAFoElffen; September 8th, 2021 at 06:43 AM.

    Concurrent coexistance of Windows, Linux and UNIX...
    Ubuntu user # 33563, Linux user # 533637
    Sticky: [all variants] Graphics Resolution- Upgrade /Blank Screen after reboot
    UbuntuForums system-info Script

  10. #270
    Join Date
    Feb 2011
    Location
    Coquitlam, B.C. Canada
    Beans
    3,040
    Distro
    Ubuntu Development Release

    Re: Inspired

    great thanks.

    Code:
    doug@s19:~/tmp/support-info$ git log --oneline
    7d757a5 (HEAD -> main, origin/main, origin/HEAD) Removed old Paster() and all traces using pastebinit
    d1eaa39 Changing file permissions
    be4d19a Update system-info
    9b9feed Update system-info
    724a966 Update UbuntuForums-README.md
    ...
    and:
    Code:
    doug@s19:~/tmp/support-info$ ls -l system-info
    -rwxrwxr-x 1 doug doug 26494 Sep  7 22:45 system-info
    Any follow-up information on your issue would be appreciated. Please have the courtesy to report back.

Page 27 of 35 FirstFirst ... 172526272829 ... LastLast

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •