Inspired

[MAFoElffen]

Let me combine and edit the two of them together... from within GetGPU() and get a format layout going for it.

I want it to show in GetGPU() more like the following

cpu                     
     description: CPU
     product: AMD Opteron(tm) Processor 6386 SE
     vendor: Advanced Micro Devices [AMD]
     physical id: 4
     bus info: cpu@0
     version: AMD Opteron(tm) Processor 6386 SE
     serial: [REMOVED]
     slot: CPU 1
     size: 1399MHz
     capacity: 2800MHz
     width: 64 bits
     clock: 200MHz
     capabilities: lm fpu fpu_exception wp vme de pse tsc msr pae mce cx8 
         apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht 
         syscall nx mmxext fxsr_opt pdpe1gb rdtscp x86-64 constant_tsc rep_good 
         nopl nonstop_tsc cpuid extd_apicid amd_dcm aperfmperf pni pclmulqdq 
         monitor ssse3 fma cx16 sse4_1 sse4_2 popcnt aes xsave avx f16c lahf_lm 
         cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch 
         osvw ibs xop skinit wdt fma4 tce nodeid_msr tbm topoext perfctr_core 
         perfctr_nb cpb hw_pstate ssbd ibpb vmmcall bmi1 arat npt lbrv svm_lock 
         nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter 
         pfthreshold lwp cpufreq
     configuration: cores=16 enabledcores=16 threads=16
       
computer                    
    description: System
    capabilities: smbios-2.6 dmi-2.6 smp vsyscall32
    configuration:
        boot=normal
        chassis=server
        family=To Be Filled By O.E.M.
        sku=To Be Filled By O.E.M.
        uuid=[REMOVED]

[sudodus]

Current code within GetCPU()

...
mafoelffen@Opti-Ubuntu-Main:~$ sudo lshw -sanitize -C cpu | sed 's/  *capabilities/capabilities/'      | fold -sw 71 |sed -e 's/^[^ ]/          &/'      -e 's/  capabilities/capabilities/'
  *-cpu                     
       description: CPU
       product: AMD Opteron(tm) Processor 6386 SE
       vendor: Advanced Micro Devices [AMD]
       physical id: 4
       bus info: cpu@0
       version: AMD Opteron(tm) Processor 6386 SE
       serial: [REMOVED]
       slot: CPU 1
       size: 1399MHz
       capacity: 2800MHz
       width: 64 bits
       clock: 200MHz
       capabilities: lm fpu fpu_exception wp vme de pse tsc msr pae mce cx8 
         apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht 
         syscall nx mmxext fxsr_opt pdpe1gb rdtscp x86-64 constant_tsc rep_good 
         nopl nonstop_tsc cpuid extd_apicid amd_dcm aperfmperf pni pclmulqdq 
         monitor ssse3 fma cx16 sse4_1 sse4_2 popcnt aes xsave avx f16c lahf_lm 
         cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch 
         osvw ibs xop skinit wdt fma4 tce nodeid_msr tbm topoext perfctr_core 
         perfctr_nb cpb hw_pstate ssbd ibpb vmmcall bmi1 arat npt lbrv svm_lock 
         nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter 
         pfthreshold lwp cpufreq
       configuration: cores=16 enabledcores=16 threads=16

I was actually getting More CPU related info previosly from scanning the cpuinfo files in /proc/... but more from lshw

From the Output, I can see your point. But I disagree on what we are showing in GetCpu() now. This needs to "replace" the lshw command in in GetCPU() The command that is there right now... All that information is in GetDmi() already ...Right?

I think this should replace what is there now. OR... Strip out and show this and strip out "capabilties" and "configuration" from the current, so there isn't overlap with GetDmi() information.

Either way, I think that somehow we should show important details about the CPU. It is OK for me to cut off the capabilities, because if necessary, we can ask specifically about it and ask the user to run lshw separately. But before deciding, let us listen to what the other helpers think about it

[MAFoElffen]

This is what I get if I do this...

#!/bin/bash

# MAFoElffen <mafoelffen@ubuntu.com>
# CPU Info

sudo lshw -sanitize -C cpu \
    | sed 's/ *capabilities/  capabilities/' \
    | fold -sw 71 \
    |sed -e 's/^[^ ]/           &/' \
    -e 's/.*-cpu/cpu/g' \
    -e 's/ capabilities/   capabilities/' \
    -e 's/       /    /' \
    -e '/capabilities/ s/^[^ ]/          &/' 

echo -e ""

sudo lshw -sanitize | sed '/*-core/,$ d' \
        | grep -v 'product\|vendor\|version\|serial\|width' \    # <-- If you comment this line out, it shows as full again...
        | sed -e 's/ *configuration/configuration/' \
        -e '/configuration/ s/ [^ ]*=[^ ]*/\n&/g' \
        -e 's/configuration/    configuration/' \
        | sed 's/^ [^ ]/       &/'

Shows as:

cpu                         
    description: CPU
    product: AMD Opteron(tm) Processor 6386 SE
    vendor: Advanced Micro Devices [AMD]
    physical id: 4
    bus info: cpu@0
    version: AMD Opteron(tm) Processor 6386 SE
    serial: [REMOVED]
    slot: CPU 1
    size: 1399MHz
    capacity: 2800MHz
    width: 64 bits
    clock: 200MHz
    capabilities: lm fpu fpu_exception wp vme de pse tsc msr pae mce cx8 
        apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht 
        syscall nx mmxext fxsr_opt pdpe1gb rdtscp x86-64 constant_tsc rep_good 
        nopl nonstop_tsc cpuid extd_apicid amd_dcm aperfmperf pni pclmulqdq 
        monitor ssse3 fma cx16 sse4_1 sse4_2 popcnt aes xsave avx f16c lahf_lm 
        cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch 
        osvw ibs xop skinit wdt fma4 tce nodeid_msr tbm topoext perfctr_core 
        perfctr_nb cpb hw_pstate ssbd ibpb vmmcall bmi1 arat npt lbrv svm_lock 
        nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter 
        pfthreshold lwp cpufreq
    configuration: cores=16 enabledcores=16 threads=16

computer                    
    description: System
    capabilities: smbios-2.6 dmi-2.6 smp vsyscall32
    configuration:
        boot=normal
        chassis=server
        family=To Be Filled By O.E.M.
        sku=To Be Filled By O.E.M.
        uuid=[REMOVED]

So more like that? (Everything else that "was there" is displayed right below that in SMBIOS.)

[sudodus]

Bugs, that are easy to see in system-info Version: 00.07-01, Script Date: 2021.09.05

1. ./system-info: line 287: mokutil: command not found

a. printed into less, and pushes the top line out of sight.

See the attached screenshot.

b. printed into the terminal after exit from less (and makes the output ugly).

./system-info: line 287: mokutil: command not found
The result is stored in '/home/olle/system-info.txt'
 Sensitive data is [REMOVED] from the report file 
Do you want to upload the report file fo 'paste.ubuntu.com'? (y/N)

I suggest that you redirect it to cyberspace like I to in my versions with 2> /dev/null (or if you don't like that , redirect to an error log file).

2. There is a plus character in the echoed line. I think you should replace it with a newline in the script code.

See the marked spot in the attached screenshot.

I have some other suggested edits too. I am not sure if you have seen them, but we can take a few steps each time. And of course, you may not like all my suggested edits and decide to skip some of them.

[oldfred]

Question on USB output.
We are using lsusb -t -vv which seems wordy?
Plain lsusb is shorter and seems to have most of the same info?
driver may be the only added info we might want?

fred@z97-focal-kubuntu:~$ lsusb 
Bus 002 Device 002: ID 8087:8001 Intel Corp.  
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub 
Bus 001 Device 002: ID 8087:8009 Intel Corp.  
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub 
Bus 004 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub 
Bus 003 Device 003: ID 2109:0715 VIA Labs, Inc. VLI Product String 
Bus 003 Device 002: ID 03f0:c511 HP, Inc ENVY 4500 series 
Bus 003 Device 005: ID 04d9:1605 Holtek Semiconductor, Inc. USB Keyboard 
Bus 003 Device 006: ID 1a2c:0042 China Resource Semico Co., Ltd Usb Mouse 
Bus 003 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

From script:

---------- USB Information:
/:  Bus 04.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/6p, 5000M
    ID 1d6b:0003 Linux Foundation 3.0 root hub
    /sys/bus/usb/devices/usb4  /dev/bus/usb/004/001
/:  Bus 03.Port 1: Dev 1, Class=root_hub, Driver=xhci_hcd/14p, 480M
    ID 1d6b:0002 Linux Foundation 2.0 root hub
    /sys/bus/usb/devices/usb3  /dev/bus/usb/003/001
    |__ Port 3: Dev 2, If 0, Class=Vendor Specific Class, Driver=, 480M
        ID 03f0:c511 HP, Inc 
        /sys/bus/usb/devices/3-3  /dev/bus/usb/003/002
    |__ Port 3: Dev 2, If 1, Class=Printer, Driver=, 480M
        ID 03f0:c511 HP, Inc 
        /sys/bus/usb/devices/3-3  /dev/bus/usb/003/002
    |__ Port 3: Dev 2, If 2, Class=Vendor Specific Class, Driver=, 480M
        ID 03f0:c511 HP, Inc 
        /sys/bus/usb/devices/3-3  /dev/bus/usb/003/002
    |__ Port 4: Dev 3, If 0, Class=Mass Storage, Driver=uas, 480M
        ID 2109:0715 VIA Labs, Inc. 
        /sys/bus/usb/devices/3-4  /dev/bus/usb/003/003
    |__ Port 13: Dev 6, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
        ID 1a2c:0042 China Resource Semico Co., Ltd 
        /sys/bus/usb/devices/3-13  /dev/bus/usb/003/006
    |__ Port 14: Dev 5, If 0, Class=Human Interface Device, Driver=usbhid, 1.5M
        ID 04d9:1605 Holtek Semiconductor, Inc. 
        /sys/bus/usb/devices/3-14  /dev/bus/usb/003/005
    |__ Port 14: Dev 5, If 1, Class=Human Interface Device, Driver=usbhid, 1.5M
        ID 04d9:1605 Holtek Semiconductor, Inc. 
        /sys/bus/usb/devices/3-14  /dev/bus/usb/003/005
/:  Bus 02.Port 1: Dev 1, Class=root_hub, Driver=ehci-pci/2p, 480M
    ID 1d6b:0002 Linux Foundation 2.0 root hub
    /sys/bus/usb/devices/usb2  /dev/bus/usb/002/001
    |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/8p, 480M
        ID 8087:8001 Intel Corp. 
        /sys/bus/usb/devices/2-1  /dev/bus/usb/002/002
/:  Bus 01.Port 1: Dev 1, Class=root_hub, Driver=ehci-pci/2p, 480M
    ID 1d6b:0002 Linux Foundation 2.0 root hub
    /sys/bus/usb/devices/usb1  /dev/bus/usb/001/001
    |__ Port 1: Dev 2, If 0, Class=Hub, Driver=hub/6p, 480M
        ID 8087:8009 Intel Corp. 
        /sys/bus/usb/devices/1-1  /dev/bus/usb/001/002

[sudodus]

@MAFoElffen,

Here are a couple of patch files. You will probably not want to use them automatically, but you can use them manually for individual bug fixes and tweaks.

Complaint about mokutil: Instead of using a stale variable, I suggest checking when it is to be used:

diff -u system-info07-01 system-info
--- system-info07-01	2021-09-06 09:48:02.612965522 +0200
+++ system-info	2021-09-06 15:45:08.203416414 +0200
@@ -271,11 +271,12 @@
     # Gets SafeBoot Info from UEFI BIOS or if not UEFI capable. Called once by GetDMI().
     # Warns user if mokutil was not present.
     #echo -e "   --- SecureBoot Status:"
-    if [ $check_mokutil -eq 0 ] 
+#    if [ $check_mokutil -eq 0 ] 
+    if ! $(which mokutil > /dev/null)
     then
         echo -e "\tThis would check / have checked if SecureBoot was enabled or not, "
-        echo -e "\t and checks if the system BIOS was UEFI or Lagacy only BIOS, "
-        echo -e "\tbut package mokutil was not installed. If you would like to check"
+        echo -e "\tand checks if the system BIOS was UEFI or Lagacy only BIOS, "
+        echo -e "\tbut package 'mokutil' was not installed. If you would like to check"
         echo -e "\tthis information, please install 'mokutil' and rerun script."
     else
         # For Legacy only BIOS, returns error: "EFI variables are not supported on this system"

A big patch file; you can use individual patches from a @@-line to the next @@-line. For example looking for sources.d will throw and error output, if nothing is found. You will find the corresponding patch around line #200 in the patch file, addressing the @@ -522,13 +510,17 @@ lines. there are several other tweaks and fixes, and you will probably like some of them and skip some other of my suggested edits.

I think the best way to see the difference is to run the two current versions, yours and mine, and look for differences. Some of them might be difficult to discover, they might only show up in a few computers/operating systems/settings.

The patch created problems to save the post, so I upload it to the pastebin https://paste.ubuntu.com/p/gfjXxsTCWT/

My current script, system-info-nio04 can be downloaded from https://paste.ubuntu.com/p/xWtHTPVYWX/.

[sudodus]

Question on USB output.
We are using lsusb -t -vv which seems wordy?
Plain lsusb is shorter and seems to have most of the same info?
driver may be the only added info we might want?

+1

[sudodus]

@oldfred,

I goofed. Managed to get two posts jailed. First the wrong one, then I tried to edit the bad one, but before I could finish it was jailed too. Please release the shorter one from jail. I think it is the better one, without a lot of junk, that probably was the reason that the system was unresponsive, and I did things without seeing what I did.

Anyway, if the jail is a black hole, I can show the two pasted files here:

- A big patch, system-info07-01_to_system-info-nio04.patch: https://paste.ubuntu.com/p/gfjXxsTCWT/

- My latest version of the system-info script: https://paste.ubuntu.com/p/xWtHTPVYWX/

And a small patch for a particular bug about mokutil, that I dare show within code tags here:

$ diff -u system-info07-01 system-info
--- system-info07-01	2021-09-06 09:48:02.612965522 +0200
+++ system-info	2021-09-06 15:45:08.203416414 +0200
@@ -271,11 +271,12 @@
     # Gets SafeBoot Info from UEFI BIOS or if not UEFI capable. Called once by GetDMI().
     # Warns user if mokutil was not present.
     #echo -e "   --- SecureBoot Status:"
-    if [ $check_mokutil -eq 0 ] 
+#    if [ $check_mokutil -eq 0 ] 
+    if ! $(which mokutil > /dev/null)
     then
         echo -e "\tThis would check / have checked if SecureBoot was enabled or not, "
-        echo -e "\t and checks if the system BIOS was UEFI or Lagacy only BIOS, "
-        echo -e "\tbut package mokutil was not installed. If you would like to check"
+        echo -e "\tand checks if the system BIOS was UEFI or Lagacy only BIOS, "
+        echo -e "\tbut package 'mokutil' was not installed. If you would like to check"
         echo -e "\tthis information, please install 'mokutil' and rerun script."
     else
         # For Legacy only BIOS, returns error: "EFI variables are not supported on this system"

[oldfred]

Found this did not work. One name not updated.
Had similar issue with MAFoElffen's github as the version I saved of the wget command was the old support-info name.

From https://github.com/UbuntuForums/system-info

wget -N -t 5 -T 10 https://github.com/Mafoelffen1/system-info/raw/main/system-info && \
chmod +x system-info && \
./support-info

Ran both MAFoElffen & sudodus versions.
In sudodus' version:
Liked the CPU info, not sure if we need all the details on capabilities?
Spacing was different on several lines. Some were just another blank so meld showed it different.
But some lines were different.
In display product & resources were one line or two, not multiple.
Sources list for ppa showed both title & detail which are the same. Years ago was it one folder for all ppas? but now is one folder per ppa.
And user changed from one line to multiple lines.

[sudodus]

@oldfred,

Are there some particular capabilities, that you think are useful, or should we skip them all?

This is what inxi displays in my computer:

$ inxi -xx -C
CPU:       Quad core Intel Xeon E5-1620 v2 (-MT-MCP-) arch: Ivy Bridge rev.4 cache: 10240 KB
           flags: (lm nx sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx) bmips: 29601
           clock speeds: min/max: 1200/3900 MHz 1: 1202 MHz 2: 1271 MHz 3: 1280 MHz 4: 1236 MHz 5: 1317 MHz
           6: 1264 MHz 7: 1258 MHz 8: 1250 MHz