New applesmc module for all models - Call for testing

[kosumi68]

New applesmc kernel module with dynamic configuration

The amount of machines supported by this module has increased
rapidly over the past years, and the detailed driver support
of the many flavors is quickly becoming a problem.

The attached dkms package contains a new, dynamically
configured driver which fixes a number of outstanding
issues:

* Support for all new models since MacbookPro 6.
* Support for variable number of processors in the MacPros.
* Handles the odd temperature sensor types found on new models.
* Fixes minor read problems on many intermediate models.

And, of course, all models back to the MacBook1,1 should work at least as well as before.

Please test and report the outcome in this thread, stating your machine model and a simple "OK" or a description of the problem. As soon as things seem to work as expected, the patches will go upstream.

Thanks!

[Niels den Otter]

FWIW. Loads fine on my Macbook 5,1.

Output previous (default 10.10 driver):

Oct 28 09:24:42 sambal kernel: [ 25.518617] applesmc: Apple MacBook 5 detected:
Oct 28 09:24:42 sambal kernel: [ 25.518620] applesmc: - Model with accelerometer
Oct 28 09:24:42 sambal kernel: [ 25.518622] applesmc: - Model with light sensors and backlight
Oct 28 09:24:42 sambal kernel: [ 25.518625] applesmc: - Model with 14 temperature sensors
Oct 28 09:24:42 sambal kernel: [ 25.583889] applesmc: device successfully initialized (0xe0, 0x00).
Oct 28 09:24:42 sambal kernel: [ 25.583891] applesmc: device successfully initialized.
Oct 28 09:24:42 sambal kernel: [ 25.586382] applesmc: 1 fans found.
Oct 28 09:24:42 sambal kernel: [ 25.646181] input: applesmc as /devices/platform/applesmc.768/input/input12
Oct 28 09:24:42 sambal kernel: [ 25.947014] Registered led device: smc::kbd_backlight
Oct 28 09:24:42 sambal kernel: [ 25.947037] applesmc: driver successfully loaded.


Output of your driver when loading;

Oct 28 20:43:04 sambal kernel: [27112.310389] applesmc: Apple MacBook detected
Oct 28 20:43:05 sambal kernel: [27112.483226] applesmc: key=271 fan=1 temp=14 acc=1, light=2, keyb=1
Oct 28 20:43:05 sambal kernel: [27112.527493] input: applesmc as /devices/platform/applesmc.768/input/input18
Oct 28 20:43:05 sambal kernel: [27112.527670] Registered led device: smc::kbd_backlight
Oct 28 20:43:05 sambal kernel: [27112.527693] applesmc: driver successfully loaded.


Both the new and original driver shows this output;

Oct 28 20:44:34 sambal kernel: [27201.814535] applesmc: wait status failed: 4 != 10
Oct 28 20:45:19 sambal kernel: [27247.138975] applesmc: wait status failed: 4 != 10

Don't know what this means.


-- Niels

[linuxopjemac]

MacBook 2,1 here.

Before installation:
jeroen@jeroen-mint ~ $ dmesg | grep smc
[ 12.979070] applesmc: Apple MacBook (v2) detected:
[ 12.979074] applesmc: - Model with accelerometer
[ 12.979076] applesmc: - Model without light sensors and backlight
[ 12.979078] applesmc: - Model with 10 temperature sensors
[ 12.979734] applesmc: device has already been initialized (0xe0, 0x00).
[ 12.979736] applesmc: device successfully initialized.
[ 12.980533] applesmc: 1 fans found.
[ 12.984063] input: applesmc as /devices/platform/applesmc.768/input/input9
[ 12.984432] applesmc: driver successfully loaded.
jeroen@jeroen-mint ~ $ dpkg -l | grep smc
rc applesmc-dkms 0.17.0~rc1 Supplementary applesmc support
jeroen@jeroen-mint ~ $




Installed without problems.
jeroen@jeroen-mint ~ $ dmesg | grep smc
[ 13.915411] applesmc: Apple MacBook detected
[ 14.104336] applesmc: key=225 fan=1 temp=10 acc=1, light=0, keyb=0
[ 14.183051] input: applesmc as /devices/platform/applesmc.768/input/input11
[ 14.183867] applesmc: driver successfully loaded.
jeroen@jeroen-mint ~ $


The line [ 14.104336] applesmc: key=225 fan=1 temp=10 acc=1, light=0, keyb=0 I didn't have before. What it used to detect was MacBook v2. Now that info seems to be lost.

[linuxopjemac]

The problem I experience now is that the screen dims by itself

update: happens with old module too...

[kosumi68]

MacBook 2,1 here.

The line [ 14.104336] applesmc: key=225 fan=1 temp=10 acc=1, light=0, keyb=0 I didn't have before. What it used to detect was MacBook v2. Now that info seems to be lost.

Thanks for testing! The new driver only contains generic model matching, and your 2.1 is still a MacBook. All special details of your particular 2.1 model are instead read dynamically via the SMC itself.

@Niels: Thanks, I will return with another package that hopefully will contain more informative error messages.

Cheers!

[kosumi68]

New version of the dkms package, with more informative warnings. Occasional read errors is not a problem, but a consistent read failure most likely is due to a misinterpretation of some data type. Knowing about such errors would be very helpful.

Thanks!

[linuxopjemac]

sudo dpkg -i applesmc-dkms_0.17.0~rc2_all.deb
[sudo] password for jeroen:
Selecting previously deselected package applesmc-dkms.
(Reading database ... 118252 files and directories currently installed.)
Unpacking applesmc-dkms (from applesmc-dkms_0.17.0~rc2_all.deb) ...
Setting up applesmc-dkms (0.17.0~rc2) ...
Loading new applesmc-0.17.0 DKMS files...

Loading tarball for module: applesmc / version: 0.17.0

Loading /usr/src/applesmc-0.17.0...
Creating /var/lib/dkms/applesmc/0.17.0/source symlink...

DKMS: ldtarball Completed.
Installing prebuilt kernel module binaries (if any)
Building module...

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area....
make KERNELRELEASE=2.6.32-21-generic -C /lib/modules/2.6.32-21-generic/build SUBDIRS=/var/lib/dkms/applesmc/0.17.0/build modules....(bad exit status: 2)

Error! Bad return status for module build on kernel: 2.6.32-21-generic (i686)
Consult the make.log in the build directory
/var/lib/dkms/applesmc/0.17.0/build/ for more information.
0
0
dpkg: error processing applesmc-dkms (--install):
subprocess installed post-installation script returned error exit status 10
Errors were encountered while processing:
applesmc-dkms


cat /var/lib/dkms/applesmc/0.17.0/build/make.log
DKMS make.log for applesmc-0.17.0 for kernel 2.6.32-21-generic (i686)
Fri Oct 29 16:10:07 CEST 2010
make: Entering directory `/usr/src/linux-headers-2.6.32-21-generic'
CC [M] /var/lib/dkms/applesmc/0.17.0/build/applesmc.o
/var/lib/dkms/applesmc/0.17.0/build/applesmc.c: In function ‘read_smc’:
/var/lib/dkms/applesmc/0.17.0/build/applesmc.c:218: error: implicit declaration of function ‘pr_warn’
make[1]: *** [/var/lib/dkms/applesmc/0.17.0/build/applesmc.o] Error 1
make: *** [_module_/var/lib/dkms/applesmc/0.17.0/build] Error 2
make: Leaving directory `/usr/src/linux-headers-2.6.32-21-generic'

[kosumi68]

sudo dpkg -i applesmc-dkms_0.17.0~rc2_all.deb

Right, pr_info and co are quite new... code defines them if not defined now, and the package in the previous post has been updated. Thanks!

[ryanczak]

Installed. Will report any problems. Does this new version of applesmc provide better fan control than the old version? I am currently using macfanctld from the mactel ppa. Is it still required?

Before:

Oct 29 10:52:10 fruit kernel: [    9.228369] applesmc: Apple MacBook Pro 7 detected:
Oct 29 10:52:10 fruit kernel: [    9.228373] applesmc:  - Model with accelerometer
Oct 29 10:52:10 fruit kernel: [    9.228375] applesmc:  - Model with light sensors and backlight
Oct 29 10:52:10 fruit kernel: [    9.228377] applesmc:  - Model with 15 temperature sensors
Oct 29 10:52:10 fruit kernel: [    9.293549] applesmc: device successfully initialized (0xe0, 0x00).
Oct 29 10:52:10 fruit kernel: [    9.293552] applesmc: device successfully initialized.
Oct 29 10:52:10 fruit kernel: [    9.294484] applesmc: 1 fans found.
Oct 29 10:52:10 fruit kernel: [    9.311559] applesmc: driver successfully loaded.
Oct 29 10:52:15 fruit kernel: [   15.155481] applesmc: light sensor data length set to 10
Oct 29 10:53:59 fruit kernel: [  121.544600] applesmc: wait status failed: 5 != 1

After:

Oct 29 10:53:59 fruit kernel: [  121.544600] applesmc: wait status failed: 5 != 1
Oct 29 10:57:00 fruit kernel: [    9.121210] applesmc: Apple MacBook Pro detected
Oct 29 10:57:00 fruit kernel: [    9.741466] applesmc: key=321 fan=1 temp=15 acc=1, light=2, keyb=1
Oct 29 10:57:00 fruit kernel: [    9.802587] input: applesmc as /devices/platform/applesmc.768/input/input10
Oct 29 10:57:00 fruit kernel: [    9.803298] applesmc: driver successfully loaded
Oct 29 10:57:06 fruit kernel: [   15.920292] applesmc: light sensor data length set to 10

[linuxopjemac]

can't install still:

jeroen@jeroen-mint ~/Downloads $ sudo dpkg -i applesmc-dkms_0.17.0~rc2_all.deb
Selecting previously deselected package applesmc-dkms.
(Reading database ... 118252 files and directories currently installed.)
Unpacking applesmc-dkms (from applesmc-dkms_0.17.0~rc2_all.deb) ...
Setting up applesmc-dkms (0.17.0~rc2) ...
Loading new applesmc-0.17.0 DKMS files...

Loading tarball for module: applesmc / version: 0.17.0

Loading /usr/src/applesmc-0.17.0...
Creating /var/lib/dkms/applesmc/0.17.0/source symlink...

DKMS: ldtarball Completed.
Installing prebuilt kernel module binaries (if any)
Building module...

Kernel preparation unnecessary for this kernel. Skipping...

Building module:
cleaning build area....
make KERNELRELEASE=2.6.32-21-generic -C /lib/modules/2.6.32-21-generic/build SUBDIRS=/var/lib/dkms/applesmc/0.17.0/build modules....(bad exit status: 2)

Error! Bad return status for module build on kernel: 2.6.32-21-generic (i686)
Consult the make.log in the build directory
/var/lib/dkms/applesmc/0.17.0/build/ for more information.
0
0
dpkg: error processing applesmc-dkms (--install):
subprocess installed post-installation script returned error exit status 10
Errors were encountered while processing:
applesmc-dkms


jeroen@jeroen-mint ~/Downloads $ cat /var/lib/dkms/applesmc/0.17.0/build/make.log
DKMS make.log for applesmc-0.17.0 for kernel 2.6.32-21-generic (i686)
Fri Oct 29 17:48:42 CEST 2010
make: Entering directory `/usr/src/linux-headers-2.6.32-21-generic'
CC [M] /var/lib/dkms/applesmc/0.17.0/build/applesmc.o
/var/lib/dkms/applesmc/0.17.0/build/applesmc.c: In function ‘read_smc’:
/var/lib/dkms/applesmc/0.17.0/build/applesmc.c:227: error: implicit declaration of function ‘pr_warn’
make[1]: *** [/var/lib/dkms/applesmc/0.17.0/build/applesmc.o] Error 1
make: *** [_module_/var/lib/dkms/applesmc/0.17.0/build] Error 2
make: Leaving directory `/usr/src/linux-headers-2.6.32-21-generic'
jeroen@jeroen-mint ~/Downloads $