Results 1 to 7 of 7

Thread: Python Code Review Request

  1. #1
    Join Date
    Jul 2007
    Location
    Virginia
    Beans
    28
    Distro
    Ubuntu 10.04 Lucid Lynx

    Python Code Review Request

    Hi all,

    I'm working on a project right now. It has a very narrow focus (a small industry will benefit from its release), but I'm wondering if someone could take time out of their busy schedule to criticize it. I'm wondering I should take a different approach to it, or implement a specific design pattern that I'm not aware of.

    Background on the project:
    It's purpose is to help energy auditors perform surveys of sites. These guys walk around and take note of electric loads (air-conditioners, resistive loads like office equipment, etc) and then plug the information into this thing.

    The source of the project is on launchpad at http://launchpad.net/eesu

    I'm also curious as to how I can implement unittesting in something like this. It's very GTK focused, and I'm just too lost when it comes to unittesting. There's no real gui/backend separation, its just all sort of folded in together.

    Any comments will be greatly appreciated. Thanks again, guys!
    http://www.nuxified.org/article/fork...ze_the_desktop
    Good enough is not enough. Being the best is not enough. - Danijel Orsolic

  2. #2
    Join Date
    Aug 2007
    Location
    UK
    Beans
    427
    Distro
    Ubuntu UNR

    Re: Python Code Review Request

    To put data into the user interface for testing I would make the application user interface elements available on D-Bus, then write the tests as a separate program.

    Minimalist D-Bus example.
    http://paste.lisp.org/display/45824

  3. #3
    Join Date
    Jul 2007
    Location
    Virginia
    Beans
    28
    Distro
    Ubuntu 10.04 Lucid Lynx

    Re: Python Code Review Request

    There's a lot of user interface elements, so that will be a challenge, but I imagine it will save that much time in testing. Thanks for the suggestion StephenF!
    http://www.nuxified.org/article/fork...ze_the_desktop
    Good enough is not enough. Being the best is not enough. - Danijel Orsolic

  4. #4
    Join Date
    Nov 2005
    Location
    Bordeaux, France
    Beans
    11,292
    Distro
    Ubuntu 12.04 Precise Pangolin

    Re: Python Code Review Request

    Including a debian/ directory in your source release is generally frowned upon (I know you didn't make a release yet, but consider that when you do). The code and the packaging should be kept separate.
    「明後日の夕方には帰ってるからね。」


  5. #5
    Join Date
    Apr 2007
    Location
    (X,Y,Z) = (0,0,0)
    Beans
    3,715

    Re: Python Code Review Request

    Quote Originally Posted by Bachstelze View Post
    Including a debian/ directory in your source release is generally frowned upon (I know you didn't make a release yet, but consider that when you do). The code and the packaging should be kept separate.
    As someone that still doesn't know how to deal with this (having reverted PycTacToe from having a debian/ folder to not and then back again), I've noticed some projects do have it. Of course, the debian/ folder included is just what's called the "Debian packaging source" (the rules and control files and needed scripts... i.e. what's left after running debian/rules clean).

    Such an approach has helped me a lot... But I'm interested in knowing the disadvantages. I've been looking at this issue several times and haven't got anything that could clear my mind a bit

  6. #6
    Join Date
    Jul 2007
    Location
    Virginia
    Beans
    28
    Distro
    Ubuntu 10.04 Lucid Lynx

    Re: Python Code Review Request

    Thanks for the replies and critiques.

    The debian directory is introduced by quickly, I need to retool it to make it work again. Quickly is so young that some of it's earlier habits don't work as well now. The original idea was to allow quickly users to push packages to launchpad that would build right away, hence the debian directory.

    I'll get it working in the future, I just want the application to run functionally from within the source tree first, then I'll tackle that bit.

    EDIT: sry to resurrect a dead thread.
    Last edited by mcphargus; July 18th, 2010 at 11:10 PM.
    http://www.nuxified.org/article/fork...ze_the_desktop
    Good enough is not enough. Being the best is not enough. - Danijel Orsolic

  7. #7
    Join Date
    Nov 2005
    Location
    Bordeaux, France
    Beans
    11,292
    Distro
    Ubuntu 12.04 Precise Pangolin

    Re: Python Code Review Request

    Quote Originally Posted by nvteighen View Post
    Such an approach has helped me a lot... But I'm interested in knowing the disadvantages. I've been looking at this issue several times and haven't got anything that could clear my mind a bit
    If someone wants to package it for inclusion in a distro's official repos, your /debian dir will get in the way, because it will not work for them. When a project has a debian/ dir in the uptream tarball, the first thing the packagers do is generally to move it away to debian.upstream/ and then create its own debian/ dir.
    「明後日の夕方には帰ってるからね。」


Tags for this Thread

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •