new xf86-input for macbooks and other multitouch-touchpads.

[dennis.jarosch]

Niño,

I wanted to edit /lib/udev/rules.d/66-xorg-synaptics.rules but it wasn't there, so I created the file with

ENV{x11_driver}="multitouch"

in it…

These instructions were for Lucid Lynx only. If you are using Karmic, you need to edit the file 11-x11-synaptics.fdi.

[NiñoScript]

Yay, it works!

I think it just needs a threshold for moving the actual cursor, when I click, sometimes the cursor moves.
I'll have fun with the code now

[kosumi68]

I am glad to see things are moving forward! Kudos to arturoc for the first gesture patch, bringing us closer to full Macbook support. Perhaps you would be interested in cleaning it up a bit and submitting it for inclusion?

[arturoc]

yeah, sure, i'm going to have some time during the weekend, will give it a try. also if someone test it and want to post some bugs...

also, i see this commit in git:

janitor: stick to kernel-style formatting

With this commit, the whole code base complies with the
kernel format style, and patches can be checked against
the kernel-provided ./scripts/checkpatch.pl

is there any style guide or something similar for the code that i can take a look, or some advice on how to organize it?

[arturoc]

here's a new version:

- basic filter for the movement so the cursor is more stable
- keep last gesture so the touchpad doesn't move after a scroll if one finger is released slightly before the other
- horizontal scroll working in the correct direction with 2 fingers


i'm going to clean the code and send you a patch, meanwhile if someone can test this and find any bug, please post here.

[kosumi68]

is there any style guide or something similar for the code that i can take a look, or some advice on how to organize it?

If you have a kernel git tree available, the perl script to run is in scripts/checkpatch.pl. I have attached a copy of that file here. To test a file, do

./checkpatch.pl --no-tree --file somefile.c

To test a patch, do

./checkpatch.pl --no-tree somepatch.patch

Cheers!

[alexmurray]

For kernel coding style see the folllowing:

http://www.kernel.org/doc/Documentation/CodingStyle
http://www.linuxjournal.com/article/5780

Since GNOME recommend the same style as well as the kernel their page on coding style also has some more info:

http://developer.gnome.org/doc/guide...ode-style.html

[mcoleman44]

You might want to take a look at this thread: http://ubuntuforums.org/showthread.php?t=1252492

It will give you some insight to all the problems were having right now with multi-touch and n-trig devices.

[arturoc]

hey

so everything seems to be working, and the checkpatch script tells there's no errors in the formatting.

i've used some constants for checking distances and times in defnes, i suppose it can be useful to be able to configure them from outside the code. also don't know if this is going to be used for other touchpads than the macbook, but i suppose some values will change in that case.

anyway, whats the best way to submit the changes?

[kosumi68]

hey

so everything seems to be working, and the checkpatch script tells there's no errors in the formatting.

i've used some constants for checking distances and times in defnes, i suppose it can be useful to be able to configure them from outside the code. also don't know if this is going to be used for other touchpads than the macbook, but i suppose some values will change in that case.

anyway, whats the best way to submit the changes?

Great! Just drop a mail to patches@bitmath.org.