Bash while loop help

[black_ice]

Hi Guys,

I'm currently working on a simple bash script that will check the current size of files inside directory and if it's larger than specific value .. the script should remove the files until it reached to specific value .. but it seems it's not working "The script always going outside the loop which is weird for me "

#!/bin/bash
CURR_DIR_SIZE=`du -sk /opt/test/ | cut -f1`
MAX_SIZE=81920

#echo $CURR_DIR_SIZE


while [[ $CURR_DIR_SIZE -gt $MAX_SIZE ]]

do
echo $CURR_DIR_SIZE

FILE=`ls -1tra test/ | head -1`
rm -rf $FILE

CURR_DIR_SIZE=`du -sk /opt/test/ | cut -f1`
done
exit 0

Any help

Thanks in advance

[sudodus]

Did you try with single brackets:

while [ $CURR_DIR_SIZE -gt $MAX_SIZE ]

[black_ice]

Thanks for reply back :

I have tried it, but it's entering endless loop !! without removing any files

[sudodus]

Do you have write permission (and hence remove permission in that directory)? Maybe rm cannot do its job.

Edit: and are you in the right directory doing it? Maybe you should use absolute path in the FILE= statement

FILE=`ls -1tra /opt/test/ | head -1`

rm -rf /opt/test/$FILE

[drmrgd]

You might consider using stat for this. something along the lines of:

MAX_SIZE=81920
while [[ $(stat -c%s $CURR_DIR_SIZE) -gt $MAX_SIZE ]]; then
    do ......

You might play with the formatting of the stat output and make sure that $MAX_SIZE matches the units correctly.

[black_ice]

Yes I do, I'm executing the script as a root ..

[sudodus]

I think the solution is absolute paths. See my previous post, it is edited twice.

[steeldriver]

I second using 'stat' instead of 'ls'

You appear to be testing the size of /opt/test but attempting to remove files from the current directory

You should also quote your $file variable in case it has spaces

I don't think there is anything wrong with your loop syntax itself (although it would be more idiomatic to use < > operators instead of -lt -gt in an extended test [[ ]] I think)

[sudodus]

i second using 'stat' instead of 'ls'

you appear to be testing the size of /opt/test but attempting to remove files from the current directory

you should also quote your $file variable in case it has spaces

i don't think there is anything wrong with your loop syntax itself (although it would be more idiomatic to use < > operators instead of -lt -gt in an extended test [[ ]] i think)

+1

[black_ice]

Thanks guys for your valuable input, but the script didn't do the desired function , here is the new code

#!/bin/bash
CURR_DIR_SIZE=`du -sk /opt/test/ | cut -f1`
MAX_SIZE=81920

#echo $CURR_DIR_SIZE


while [[ $CURR_DIR_SIZE > $MAX_SIZE ]]
do
#echo $CURR_DIR_SIZE

FILE=`ls -1htr /opt/test/ | head -1`
rm -rf /opt/test/$FILE

done
exit 0

Bash -x

# bash -x RemoveFiles.sh
++ du -sk /opt/test/
++ cut -f1
+ CURR_DIR_SIZE=164020
+ MAX_SIZE=81920
+ [[ 164020 > 81920 ]]
+ exit 0