Bash script failing (detect if ping successful)

[Muscovy]

I've been making a bash script that involves checking if it can ping. I swear it was working before, but now it throws On or Off depending on if I commend or uncomment the first line here.

The purpose of the while loop is to keep looping until it can successfully ping.

#Internet=0
while [ ! $Internet ]
  do
  ping -c 1 -w 3 google.com
  if [ $? -ne  ] ; then
    $Internet = 0
    echo Off
  else
    $Internet = 1
    echo On
  fi
  #More code.
done

[jamesisin]

Try setting the first line to Internet= (that's right, nothing). Then what is the output?

[Muscovy]

The definition isn't skipping the while loop any more, but pings are still always returned as true.

[Muscovy]

Also, I've been getting the following errors.

/usr/bin/alexandos-stats: line 7: [: 2: unary operator expected
/usr/bin/alexandos-stats: line 11: =: command not found

Which I read up on as "non fatal", and doing the recommended solution of wrapping the problem code in quotes makes it always print Off.

[jamesisin]

I can't make sense of those errors counting your line numbers. Is that the entire script?

[Muscovy]

Whoops. Found it.

  if [ $? -ne 0 ] ; then

I accidentally deleted the value it was looking for in the returned data from pinging.

[jamesisin]

Doh! Great news. Mark your thread as SOLVED.