HOWTO Fix A Buggy DSDT File

[tedrampart]

Thanks a lot.

what did these errors fix? anything I should notice?

[Hated On Mostly]

Hi 67GTA,

Can you work your magic on mine?

Thanks

7 Errors, 9 Warnings, 1 Remarks, 831 Optimizations

For a Dell D830

[67GTA]

Thanks a lot.

what did these errors fix? anything I should notice?

You shouldn't notice much difference. The one error was actually a syntax error that the kernel is able to work around. I didn't go through the full 675 optimizations, so not sure what was automatically tweaked. You can tell iasl to be verbose with

iasl -tc -vo /path_to_dsdt.dsl

This will show info for each optimization that the compiler knows how to fix.

[67GTA]

Hated On Mostly:

Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 828 Optimizations

dsdt.aml.zip

[sergiom99]

Another trick I've learned during this process is to specify the operating system at boot. More about this is explained in the links I provided. I found that by adding

acpi_osi="Linux"

to the boot options, the operating system even saw my hardware differently at boot. This seems to be very affective on HP laptops with Vista preinstalled. I outlined these steps here: http://www.linuxmint.com/forum/viewt...p?f=60&t=18222

Hey 67GTA, great work you're doing here!

I saw in that link that, after all, adding this parameter to the GRUB was not needed in Ubuntu. Is that right?
Regards- Sergio

[67GTA]

It really depends on your DSDT. Search through it for "OSI". If there are no instances of split methods, then you won't have to worry about adding the osi definition. Most of the newer HP laptops require the osi to be defined for the temperature to stay within the limits because there are two seperate methods for temps. One for Windows, and one for Linux. The kernel won't read either unless it's osi is defined and just make a guess.

[Hated On Mostly]

Hated On Mostly:

Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 828 Optimizations

dsdt.aml.zip

Thanks 67GTA,

No more errors, but it appears all of the optimizations got wiped out.

0 Errors, 0 Warnings, 0 Remarks, 5 Optimizations

[sergiom99]

It really depends on your DSDT. Search through it for "OSI". If there are no instances of split methods, then you won't have to worry about adding the osi definition. Most of the newer HP laptops require the osi to be defined for the temperature to stay within the limits because there are two seperate methods for temps. One for Windows, and one for Linux. The kernel won't read either unless it's osi is defined and just make a guess.

I do have an OSI instance.
When trying to compile I got 2 Errors, 6 Warnings, 0 Remarks, 1127 Optimizations

 $ iasl -tc /home/sergio/dsdt.dsl

Intel ACPI Component Architecture
ASL Optimizing Compiler version 20081204 [Jan 10 2009]
Copyright (C) 2000 - 2008 Intel Corporation           
Supports ACPI Specification Revision 3.0a

/home/sergio/dsdt.dsl   104:     Method (\_WAK, 1, NotSerialized)
Warning  1080 -                              ^ Reserved method must return a value (_WAK)

/home/sergio/dsdt.dsl  3540:                 Method (_Q16, 0, NotSerialized)
Warning  1087 -    Not all control paths return a value ^  (_Q16)

/home/sergio/dsdt.dsl  7714:                 Method (_HOT, 0, Serialized)
Warning  1087 -    Not all control paths return a value ^  (_HOT)

/home/sergio/dsdt.dsl  7714:                 Method (_HOT, 0, Serialized)
Warning  1080 -     Reserved method must return a value ^  (_HOT)

/home/sergio/dsdt.dsl  7716:                     Zero
Error    4095 -                                     ^ syntax error, unexpected PARSEOP_ZERO

/home/sergio/dsdt.dsl  7723:                 Method (_CRT, 0, Serialized)
Warning  1087 -    Not all control paths return a value ^  (_CRT)

/home/sergio/dsdt.dsl  7723:                 Method (_CRT, 0, Serialized)
Warning  1080 -     Reserved method must return a value ^  (_CRT)

/home/sergio/dsdt.dsl  7725:                     Zero
Error    4095 -                                     ^ syntax error, unexpected PARSEOP_ZERO

ASL Input:  /home/sergio/dsdt.dsl - 8137 lines, 278758 bytes, 4173 keywords
Compilation complete. 2 Errors, 6 Warnings, 0 Remarks, 1127 Optimizations
sergio@kubuntu:~$

Could you please take a look at my file?
thanks!

[67GTA]

sergiom99:

Compilation complete. 0 Errors, 0 Warnings, 0 Remarks, 1130 Optimizations

Yours was exactly like mine. I fixed errors for wake from suspend/hibernate and temp readings. It will run cooler/quieter with the custom DSDT. You will definitely want to add the acpi_osi="Linux" definition for yours. Keep a copy of your dmesg output from before and after. You will be able to see the difference, escpecially with your temp being read correctly instead of being guessed at.

dsdt.aml.zip

[sergiom99]

wow dude! Thanks a lot!!

I already added the osi definition in my GRUB line before starting the whole DSDT process.
Will be loading your file right now.

Do I need to do this everytime I update the kernel from the repos?