PDA

View Full Version : Image Previews in Firefox File Upload Dialogue


aysiu
October 19th, 2007, 03:55 PM
Someone has already filed a bug report on this, but I think this bears getting some extra attention:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/89381

Description
When you are at a website like ImageShack, Facebook, the Ubuntu Forums or pretty much any site that allows you to upload images, you can't preview those images when you choose the file through Firefox on Ubuntu (works fine on Firefox in Windows). This is silly, especially for people trying to choose pictures from hundreds of weirdly named files in a directory. Galeon and Konqueror allow you to preview files. Why not Firefox, which is the default web browser on Ubuntu?

Use Case
Angela imports hundreds of photos off her camera to her hard drive. She doesn't rename the files, and they're all named something like DSCN3000324.JPG. She wants to upload three or four of her favorite photos to Flickr to share with friends. She opens Firefox, goes to Flickr, tries to upload a photo but sees only a bunch of files like DSCN3000323.JPG and DSCN3000325.JPG. She has no idea, based on the file names alone, which are her favorites. So she has to open Nautilus, navigate to the folder again, and then find the numbers of her favorite photos and keep Alt-Tabbing between Firefox and Nautilus to make sure she's uploading the correct photos. Angela would love to just have image previews through Firefox without having to load Nautilus.

Implementation
Whatever they did for Galeon, just repeat it for Firefox.

23meg
October 19th, 2007, 04:01 PM
There's a patch attached in the bug that implements the feature; has anyone tested it?

aysiu
October 19th, 2007, 04:04 PM
There's a patch attached in the bug that implements the feature; has anyone tested it?
How do you test a patch? Do you have compile Firefox from source to do it?

smartboyathome
October 19th, 2007, 06:47 PM
Yes you do, aysiu. You have to run patch -p1 patchname.patch in the firefox source folder before compiling, and then you can compile/install.

robbert
October 20th, 2007, 09:40 AM
apt-get source firefox
sudo apt-get build-dep firefox
cd firefox-2.0.0.6+2nobinonly/
cd debian/patches
wget http://launchpadlibrarian.net/9518191/ff2filepickerpreview.diff
gedit series
Add a new line with ff2filepickerpreview.diff
cd ../..
debchange -i
dpkg-buildpackage -rfakeroot -b
sudo dpkg -i ../firefox*.deb

Zdravko
October 20th, 2007, 01:44 PM
What is the connection with Hardy Heron?

aysiu
October 20th, 2007, 02:20 PM
What is the connection with Hardy Heron?
We're hoping that image previews will find their way into Hardy Heron.

23meg
January 18th, 2008, 11:41 PM
This is now implemented in Hardy's FF3.

kripkenstein
January 19th, 2008, 03:04 AM
This is now implemented in Hardy's FF3.
This is a great feature, I just noticed it the other day when I was uploading screenshots to a bug report.

Ironic, though, that I can preview images to upload in Firefox that I can't later view in Firefox due to other bugs ;)

RawMustard
January 19th, 2008, 08:48 AM
About time they did this for nautilus file chooser :(